Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add notes for embroider 16th May #503

Merged
merged 1 commit into from
May 23, 2023
Merged

add notes for embroider 16th May #503

merged 1 commit into from
May 23, 2023

Conversation

mansona
Copy link
Member

@mansona mansona commented May 16, 2023

No description provided.

- this is specifically for ember-cli (doing some broccoli specific things)
- looking at the PR again, we can probably just use JSON.stringify and compare the strings
- and that would mean we wouldn't need to add a test
- PS: I'll update the PR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR updated

- high-level overview is that changesets doesn't work with our needs
- too much work to make it work the way we need
- (demo of the new release infrastructure)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

related: embroider-build/embroider#1430 (changeset removal PR)

@mansona mansona merged commit 50fcee4 into master May 23, 2023
@mansona mansona deleted the embroider-05-16 branch May 23, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants