This repository has been archived by the owner on Aug 24, 2022. It is now read-only.
Drop NodeJs 6, 8, 11 #557
Merged
Drop NodeJs 6, 8, 11 #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No it isn't recommended, but we have to do the work to actually remove it. For now, we should:
Also, the merged RFC for removing ember-cli-eslint is here, but its original proposed location (and all of the conversation) is in ember-cli/rfcs#121. |
rwjblue
approved these changes
Jan 8, 2020
This was referenced Jan 10, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it still recomended to use ember-cli-template-lint @rwjblue ? It is still shipped with ember-cli's default blueprints. So I would assume a yes. Plus, I haven't found any RFC to deprecate usage of ember-cli-eslint and ember-cli-template-lint. But would this change require an RFC at all?
In the meantime, let's drop Node 6 / 8 / 11, it will allow dependabot to merge a few PRs. And ember-cli-template-lint is still in a beta cycle, so no major bump would be required?