Skip to content

Commit

Permalink
Include polyfill for Ember 3.4
Browse files Browse the repository at this point in the history
This is a more conservative version of the existing PR:
#123.

In Ember 3.4 (w/o the polyfill), angle-bracket invocations do not work
properly in some cases. For example:

- `<FooBar class="some-class" />`
- `<FooBar data-test="some-data-test" />`
  • Loading branch information
twokul committed May 18, 2022
1 parent a9b56fa commit fafa964
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
13 changes: 10 additions & 3 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: CI

on: [push]
on: [push, pull_request]

jobs:
test:
Expand All @@ -27,6 +27,7 @@ jobs:

try-scenarios:
name: ${{ matrix.ember-try-scenario }}
continue-on-error: ${{ matrix.allow-failure }}

runs-on: ubuntu-latest

Expand All @@ -43,10 +44,16 @@ jobs:
- ember-3.2
- ember-3.3
- ember-lts-3.4
- ember-lts-3.8
- ember-lts-3.28
- ember-default

allow-failure: [false]

include:
- ember-try-scenario: ember-lts-3.8
allow-failure: true
- ember-try-scenario: ember-lts-3.28
allow-failure: true

steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
Expand Down
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ module.exports = {
let checker = new VersionChecker(this.project);
let emberVersion = checker.forEmber();

this.shouldPolyfill = emberVersion.lt('3.4.0-alpha.1');
this.shouldPolyfill = emberVersion.lt('3.5.0-alpha.1');
this.shouldPolyfillNested = emberVersion.lt('3.10.0-alpha.1');
this.shouldPolyfillBuiltinComponents = emberVersion.lt('3.10.0-alpha.1');

Expand Down

0 comments on commit fafa964

Please sign in to comment.