Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream dependency got updated - PHP with version 8.4.1 #348

Open
3 of 4 tasks
ember-nexus-bot opened this issue Nov 22, 2024 · 2 comments
Open
3 of 4 tasks

Upstream dependency got updated - PHP with version 8.4.1 #348

ember-nexus-bot opened this issue Nov 22, 2024 · 2 comments
Assignees
@Syndesi
Labels
Dependency Update Managing dependency updates.
Milestone
0.2.0

Comments

@ember-nexus-bot
Copy link
Member

ember-nexus-bot commented Nov 22, 2024 •
edited by Syndesi
Loading

Open tasks:

  • Compare Dockerfile of latest PHP alpine CLI with ./docker/Dockerfile on intermediate build php_embed.
  • If there are updates:
    • Update local Dockerfile.
    • Add changelog entry.
    • Release new patch or minor release, depending on PHP version upgrade.
@ember-nexus-bot ember-nexus-bot added the Dependency Update Managing dependency updates. label Nov 22, 2024
@Syndesi
Copy link
Member

Syndesi commented Nov 23, 2024 •
edited
Loading

Todo:

  • Check how to fix the following notice: WARN: UndefinedVar: Usage of undefined variable '$PHP_CFLAGS' (line 12)
  • Check how to fix the following notice: Deprecated: Constant E_STRICT is deprecated in /usr/local/lib/php/pearcmd.php on line 441
  • Compare Dockerfile of Alpine 3.20 PHP 8.3 CLI with Alpine 3.20 PHP 8.4 CLI and those of Ember Nexus.
  • Check whether debug output should be disabled for the time being. If it is getting disabled, then we should have some ci test or open issue to periodically check for new deprecations. See also https://stackoverflow.com/questions/24559842/turning-off-deprecation-warnings-in-php-ini-file-wamp .

Syndesi added a commit that referenced this issue Nov 23, 2024
@Syndesi
Upgrade PHP to 8.4.1
dab7e8d 
### Changed
- Upgrade PHP to 8.4.1, closes #348.
- Update dependencies, related to #348.
@Syndesi Syndesi added this to the 0.2.0 milestone Nov 23, 2024
@Syndesi Syndesi moved this to In Progress in API Feature Progress Nov 23, 2024
Syndesi added a commit that referenced this issue Nov 24, 2024
@Syndesi
Disable psalm for the time being.
1d190f5 
### Changed
- Update code style, related to #348.
- Disable psalm for the time being, as it does not support PHP 8.4 yet. Activation is being tracked in ticket #349.
@Syndesi
Copy link
Member

Syndesi commented Nov 29, 2024

Deprecation messages can not be easily deactivated, and even if I do, then it might turn out to be a problem for new deprecations in the future.

Therefore I will halt further progress in this ticket until upstream fixes are rolled out, especially thecodingmachine/safe#442 (already on the way)

@Syndesi Syndesi moved this from In Progress to Blocked in API Feature Progress Nov 29, 2024
Syndesi added a commit that referenced this issue Nov 29, 2024
@Syndesi
Upgrade PHP to 8.4.1
e9fa564 
### Changed
- Upgrade PHP to 8.4.1, closes #348.
- Update dependencies, related to #348.
- Update code style, related to #348.
- Disable psalm for the time being, as it does not support PHP 8.4 yet. Activation is being tracked in ticket #349.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Syndesi Syndesi

Labels
Dependency Update Managing dependency updates.
Projects
API Feature Progress
Status: Blocked
Milestone
0.2.0
Development

No branches or pull requests
2 participants
@Syndesi @ember-nexus-bot