Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relations between group elements #188

Closed
Syndesi opened this issue Nov 17, 2023 · 0 comments · Fixed by #207
Closed

Fix relations between group elements #188

Syndesi opened this issue Nov 17, 2023 · 0 comments · Fixed by #207
Labels
Bug Addressing unexpected issues. Security Addressing security-related tasks.
Milestone

Comments

@Syndesi
Copy link
Member

Syndesi commented Nov 17, 2023

Relates to #163 .

Relations between group elements can not currently be returned, instead the API throws a 404 error.

https://github.com/ember-nexus/api/blob/main/src/Security/AccessChecker.php#L180

Example:

curl http://localhost/55d36907-283e-4877-aede-2c4503edee1b -H "Authorization: Bearer secret-token:INirKZbnZETk6hLD86rfrL" | jq
{
  "type": "http://localhost/error/404/not-found",
  "title": "Not found",
  "status": 404,
  "detail": "Requested element was not found.",
  "exception": {},
}
@Syndesi Syndesi added the bug label Nov 17, 2023
@Syndesi Syndesi added this to the 0.1.0 milestone Nov 17, 2023
@Syndesi Syndesi moved this to In Progress in API Feature Progress Dec 8, 2023
Syndesi added a commit that referenced this issue Dec 8, 2023
fixes #188. Uncommented and fixed assertions in feature tests, related to #188.
@github-project-automation github-project-automation bot moved this from In Progress to Done in API Feature Progress Dec 8, 2023
@Syndesi Syndesi added Bug Addressing unexpected issues. Security Addressing security-related tasks. labels May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Addressing unexpected issues. Security Addressing security-related tasks.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant