Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to fully using babel.config.js when possible #102

Closed
chriskrycho opened this issue Oct 26, 2021 · 1 comment
Closed

Switch to fully using babel.config.js when possible #102

chriskrycho opened this issue Oct 26, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@chriskrycho
Copy link
Contributor

In #101, I introduced @babel/eslint-parser to replace the deprecated babel-eslint-parser. It correctly requires you to specify your config explicitly. However, because of the issues ID'd in emberjs/ember-cli-babel#418, we cannot switch to using it throughout, and so instead are using it only for linting presently. Once the upstream design issues are resolved, update to use it directly.

@chriskrycho chriskrycho added the enhancement New feature or request label Oct 26, 2021
chriskrycho added a commit that referenced this issue Jan 24, 2022
Related to #101 and #102. Bumping to latest Embroider internals exposed
some further issue with Babel grabbing the `babel.config.js` used to
configure ESLint via `@babel/eslint-parser`. This is a temporary
workaround to unblock CI to work more generally, and which is "fine"
for now because we don't actually have any unusual syntax in this repo.
We will need to do *some* work upstream to finish fixing that more
generally for the ecosystem as a whole, though.
@chriskrycho
Copy link
Contributor Author

Done in #296!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant