Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme #8

Merged
merged 2 commits into from
Nov 20, 2018
Merged

Update Readme #8

merged 2 commits into from
Nov 20, 2018

Conversation

jayjayjpg
Copy link
Collaborator

Add some basic information on what this app's purpose is and how users can set their Github API token correctly.

Closes #5

Copy link
Member

@kennethlarsen kennethlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good ✨

Should there be any info regarding the scope of permissions when generating a token? (Is there any specific scope needed?)

@jayjayjpg
Copy link
Collaborator Author

@kennethlarsen Thank you for the suggestion, I just updated it accordingly ✨

Copy link
Member

@kennethlarsen kennethlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect ✨

@jayjayjpg jayjayjpg merged commit 9ea2eed into master Nov 20, 2018
@amyrlam amyrlam deleted the update-readme branch January 29, 2020 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants