Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember data guides to use @ember-data packages #814

Merged
merged 10 commits into from
Jan 13, 2020

Conversation

bmac
Copy link
Contributor

@bmac bmac commented May 25, 2019

No description provided.

@jenweber
Copy link
Contributor

Thank you so much @bmac!

Notes to maintainers - the gameplan here is that for 3.11, we cut a release of the Guides, and then merge this in immediately so it shows up for 3.11 users but not 3.10. I added a label and an issue to help remind us #825

@jenweber jenweber changed the title Update ember data guides to use @ember-data packages Update ember data guides to use @ember-data packages - WIP for 3.11 May 30, 2019
@jenweber jenweber changed the title Update ember data guides to use @ember-data packages - WIP for 3.11 [3.11] Update ember data guides to use @ember-data packages - WIP May 30, 2019
@jenweber jenweber changed the title [3.11] Update ember data guides to use @ember-data packages - WIP [3.11] Update ember data guides to use @ember-data packages May 30, 2019
@locks
Copy link
Contributor

locks commented Jun 28, 2019

@jenweber we can do both in this PR because we need a commit creating the 3.10 folder, right?

@locks locks force-pushed the update-model-guides branch from fa92f80 to b18b78d Compare June 28, 2019 02:31
@locks
Copy link
Contributor

locks commented Jun 28, 2019

Rebased to resolve conflicts.

@jenweber
Copy link
Contributor

We can update, re-review, and merge, when the generators match the style of this PR. The generators currently produce:

import DS from 'ember-data';
const { Model } = DS;

export default Model.extend({

});

I'm marking this PR as WIP. Please let us know when we should take another look!

@jenweber jenweber changed the title [3.11] Update ember data guides to use @ember-data packages WIP - Update ember data guides to use @ember-data packages Aug 20, 2019
@jamescdavis
Copy link
Contributor

The blueprints were updated to use package imports in emberjs/data#6358, which was released in [email protected]

@locks locks force-pushed the update-model-guides branch from b18b78d to 245f86a Compare January 13, 2020 12:53
@locks locks changed the title WIP - Update ember data guides to use @ember-data packages Update ember data guides to use @ember-data packages Jan 13, 2020
@locks locks requested a review from a team January 13, 2020 13:30
@locks locks force-pushed the update-model-guides branch from 55eae62 to a2806d4 Compare January 13, 2020 14:27
@jenweber jenweber removed the on hold label Jan 13, 2020
@locks locks merged commit d572c71 into ember-learn:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants