Add "Remove jQuery" guide #64
Conversation
|
Hm, the failing tests seem to be unrelated! (broken link in |
|
@simonihmig the old PR was marked WIP - should this one be merged in or is more work needed? |
|
I think it should be ok as is. For the old one it was still unclear in which version of Ember the RFC would be implemented, but this is clear now to be 3.3 AFAICT. |
|
Weren't we going to have a top-level "Optional Features" section? |
|
@jenweber @locks I think we should try to get this merged. Open questions:
|
|
@locks do you want to find a home for this? Otherwise I would like to make it a fairly generic url (since urls are forever) and merge. |
|
Also thanks @simonihmig for your patience. We have let it go too long without a firm decision. The hesitation is that once a url is made in the guides, it becomes something we have to maintain indefinitely, or we break a whole lot of people's urls that point to |
locks
force-pushed
the
add-jquery-opt-out
branch
from
fa44a46 to
a0858fc
Compare
|
@locks do you have a decision on where this should go? I suggest we get it in within the next week or so. This PR was still open as of creating the 3.5 release. This means before this PR to be merged, any changes requested should be made, and then the same additions should be applied to the upcoming 3.5 version files. They will be available later this week. Sorry about the extra step! |
locks
force-pushed
the
add-jquery-opt-out
branch
from
a0858fc to
6c9e5dd
Compare
|
I backported to the v3.3 guides since the optional feature was introduced in that release. |
|
Looks good to me! I would like to hear from @simonihmig before we merge. Thanks @locks! |
| The Ember framework comes by default with jQuery integration. | ||
| It is used for event handling, and to provide some APIs like `this.$()` in components. | ||
|
|
||
| With the release of ember-source v3.0.0, an optional feature flag was introduced that allows users to opt out of jQuery. |
There was a problem hiding this comment.
Should be 3.3.0! (also requires Ember CLI 3.4.0 to work properly)
|
|
||
| Once you see a feature that you would like to toggle for your project you can run one of two commands, `ember feature:enable <feature>` and `ember feature:disable <feature>`. | ||
|
|
||
| Let us disable `template-only-glimmer-components` to see what happens: |
There was a problem hiding this comment.
That feature is not listed under the Available features output above. Should we add that?
locks
force-pushed
the
add-jquery-opt-out
branch
from
bfa25a4 to
99053a0
Compare
Based on RFC 294.
I basically just resubmitted emberjs/guides#2191, which @jenweber already reviewed back then...