Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to ember-cli 3.20 and other dependencies #75

Merged
merged 2 commits into from
Aug 19, 2020
Merged

Conversation

nickschot
Copy link
Contributor

@nickschot nickschot commented Aug 15, 2020

Makes #74 unnecessary.

Ideally we need ember-showdown-prism to be released with empress/ember-showdown-prism#4 so we dont have to rely on the branch version. done, PR updated.

Needs #76 to build properly. updated

Edit: This was originally including #77 but @mansona split that out into a separate PR 👍

@nickschot nickschot requested a review from mansona August 15, 2020 12:03
@nickschot nickschot changed the title re-order (dev)dependencies to make them correct, upgrade to ember-cli 3.20 WIP: re-order (dev)dependencies to make them correct, upgrade to ember-cli 3.20 Aug 15, 2020
@nickschot
Copy link
Contributor Author

nickschot commented Aug 15, 2020

Not entirely sure why netlify's build is failing with the weird ember-data error. Might be a cache thing. I don't have the power to restart the build.

EDIT: also ran into this locally just now. Seems indeed to be a caching issue as removing node_modules & npm i fixes it. See also: emberjs/data#7221

@nickschot nickschot changed the title WIP: re-order (dev)dependencies to make them correct, upgrade to ember-cli 3.20 re-order (dev)dependencies to make them correct, upgrade to ember-cli 3.20 Aug 17, 2020
@nickschot nickschot force-pushed the fix-dependencies branch 2 times, most recently from e142a32 to 79474c9 Compare August 17, 2020 15:08
@nickschot
Copy link
Contributor Author

nickschot commented Aug 17, 2020

So indeed, tests work, netlify needs its node_modules cache to be deleted.

@mansona
Copy link
Member

mansona commented Aug 17, 2020

so... I had to rebuild the Netlify because it failed originally, but now it is passing but throwing a strange error in the build for some of the pages 🤔 TypeError: Cannot read property 'rest' of undefined any ideas? https://app.netlify.com/sites/empress-blog-ember-template/deploys/5f3aa5d8ad43c451b3a78e84

@nickschot
Copy link
Contributor Author

nickschot commented Aug 17, 2020

Yes this is what I made the other PR for in the showdown-prism repo. This error happens when you pass a language to the markdown codeblock which isn't supported by prism or it's config. I replaced the "sh" occurrences with bash already, maybe I missed some more?

EDIT: The "dummy" content indeed also contains hbs (should be handlebars) and yaml which was not included as a plugin. I added a configuration to this for now which also includes yaml. Also created a PR for ember-showdown-prism to include yaml by default. If you agree with that we can remove the configuration from this PR again.

@mansona mansona changed the title re-order (dev)dependencies to make them correct, upgrade to ember-cli 3.20 upgrade to ember-cli 3.20 and other dependencies Aug 19, 2020
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@mansona mansona merged commit 97dbac0 into master Aug 19, 2020
@nickschot nickschot deleted the fix-dependencies branch August 19, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants