-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to ember-cli 3.20 and other dependencies #75
Conversation
464c05c
to
00d5ba2
Compare
Not entirely sure why netlify's build is failing with the weird ember-data error. Might be a cache thing. I don't have the power to restart the build. EDIT: also ran into this locally just now. Seems indeed to be a caching issue as removing node_modules & npm i fixes it. See also: emberjs/data#7221 |
159a185
to
674ee25
Compare
e142a32
to
79474c9
Compare
So indeed, tests work, netlify needs its node_modules cache to be deleted. |
so... I had to rebuild the Netlify because it failed originally, but now it is passing but throwing a strange error in the build for some of the pages 🤔 |
Yes this is what I made the other PR for in the showdown-prism repo. This error happens when you pass a language to the markdown codeblock which isn't supported by prism or it's config. I replaced the "sh" occurrences with bash already, maybe I missed some more? EDIT: The "dummy" content indeed also contains |
79474c9
to
00077e8
Compare
00077e8
to
c0e1ba5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
Makes #74 unnecessary.Ideally we need ember-showdown-prism to be released with empress/ember-showdown-prism#4 so we dont have to rely on the branch version.done, PR updated.Needs #76 to build properly.updatedEdit: This was originally including #77 but @mansona split that out into a separate PR 👍