-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /logos/ route new sections and anchor links #1009
Add /logos/ route new sections and anchor links #1009
Conversation
✅ Deploy Preview for ember-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution 🎉 can you just remove the yarn.lock and we can get this merged? we're just using npm on this project so we don't have a yarn.lock file here 👍
It looks like the anchors on the Mascots aren't working. If you follow the new links on the Brand page, the URL is updating, but the mascots page jumps back to the top. Just me? This looks otherwise amazing, thank you @samridhivig so much for doing the work, and sorry I've been offline and haven't said that sooner! |
Same here, in the preview and running it locally ;) I'll check at the learning meeting if somebody there knows why. |
So this came up a long time ago when I tried to implement the same thing. The issue is that we need to enable an experimental feature on Fastboot that will allow this to work as expected 🙈 (It's EXPERIMENTAL_RENDER_MODE_SERIALIZE for reference) We discussed this in the Learning team today and we think it's probably best to update this PR to not include the links to the specific Tomsters/Zoes and we can fix the linking problem in a different PR. Essentially we're not 100% comfortable enabling the experimental feature without testing it and we didn't want to block the other important bits of this PR. What do you think? |
dc5c442
to
d5b8a6e
Compare
It turns out we figured out how to make the links work with #1120 so I've rebased this and if the links are working on the demo site I'll get it merged 👍 |
This MR works on the Copy/Content Updates to /logos/ page #1007 issue tasks:
mascot.id