Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update linting, bump deps #1010

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Update linting, bump deps #1010

merged 2 commits into from
Dec 1, 2021

Conversation

RobbieTheWagner
Copy link
Member

No description provided.

@gilest
Copy link
Contributor

gilest commented Nov 22, 2021 •
edited
Loading

@rwwagner90 I think this LinkComponent import will need ember-legacy-built-in-components to support v4.

@RobbieTheWagner
Copy link
Member Author

@gilest would you perhaps be interested in opening a PR for that?

@gilest
Copy link
Contributor

gilest commented Nov 26, 2021

@gilest would you perhaps be interested in opening a PR for that?

Sure thing it's #1015 😄

@RobbieTheWagner
Copy link
Member Author

@gilest it seems like we still have the same failures on beta and canary. Any ideas?

@RobbieTheWagner RobbieTheWagner merged commit c00ee1a into master Dec 1, 2021
@RobbieTheWagner RobbieTheWagner deleted the update-things branch December 1, 2021 14:15
@gilest
Copy link
Contributor

gilest commented Dec 1, 2021

@gilest it seems like we still have the same failures on beta and canary. Any ideas?

Looks like you got some PRs that fixed it. Thanks for the release – my CI is green again 🙌🏻

@RobbieTheWagner
Copy link
Member Author

Looks like you got some PRs that fixed it. Thanks for the release – my CI is green again 🙌🏻

Glad to hear it! My builds are still not green somehow 😂

SergeAstapov
SergeAstapov reviewed Dec 2, 2021
View reviewed changes
babel.config.js
@@ -0,0 +1,12 @@
/* eslint-env node */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwwagner90 don't want to be show stopper, from emberjs/ember-cli-babel#418 I got impression that addons should not ship babel.config.js

@SergeAstapov SergeAstapov mentioned this pull request Dec 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeAstapov SergeAstapov SergeAstapov left review comments

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RobbieTheWagner @gilest @SergeAstapov