-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ember Data is a secret dependency breaking consumers of ec-addon-docs #818
Labels
Comments
shamrt
added a commit
to rewardops/ember-react-components
that referenced
this issue
Jun 10, 2021
ctjhoa
pushed a commit
to ctjhoa/ember-ajax-fetch
that referenced
this issue
Oct 7, 2021
Needed for ember-cli-addon-docs ... ember-learn/ember-cli-addon-docs#818
ctjhoa
pushed a commit
to ctjhoa/ember-ajax-fetch
that referenced
this issue
Oct 7, 2021
Needed for ember-cli-addon-docs ... ember-learn/ember-cli-addon-docs#818
mrloop
pushed a commit
to qonto/ember-amount-input
that referenced
this issue
Sep 7, 2022
ember-cli-addon-docs requires ember-data. Removed previously #380 ember-learn/ember-cli-addon-docs#818
mrloop
pushed a commit
to qonto/ember-amount-input
that referenced
this issue
Sep 7, 2022
ember-cli-addon-docs requires ember-data. Removed previously #380 ember-learn/ember-cli-addon-docs#818
mrloop
pushed a commit
to qonto/ember-amount-input
that referenced
this issue
Sep 7, 2022
ember-cli-addon-docs requires ember-data. Removed previously #380 ember-learn/ember-cli-addon-docs#818
mrloop
pushed a commit
to qonto/ember-amount-input
that referenced
this issue
Sep 7, 2022
ember-cli-addon-docs requires ember-data. Removed previously #380 ember-learn/ember-cli-addon-docs#818
I just ran into this issue when trying to upgrade my addon to Ember 4.x. I didn't realize that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's marked as a
peerDependency
, but it is required for ec-addon-docs to run properly. If the consuming project does not haveember-data
in its package.json, ec-addon-docs breaks and throws an error, and the docs will not render. However, we can't specify it as a dependency within ec-addon-docs, either.Addons do not ship with ember-data by default, as it is not part of the addon blueprint. Most addons don't have a need to install it either, as most addons won't be doing any data fetching. So, we cannot count on ember-data to be present in order to ship a working experience to users of this project.
There are three possible solutions which could be used in conjunction with one another:
ember install
The text was updated successfully, but these errors were encountered: