Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog(embertimes95): templates colocation rfc #90

Merged
merged 1 commit into from
Apr 23, 2019

Conversation

chrisrng
Copy link
Member

  • templates colocation rfc
  • fixed link to embertimes

- templates colocation rfc
- fixed link to `embertimes`
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great! Thank you for another excellent writeup this week 🐯

@jayjayjpg jayjayjpg merged commit 7f31de7 into blog/embertimes-95 Apr 23, 2019
@chrisrng chrisrng deleted the chrisrng-patch-1 branch April 23, 2019 20:56
@amyrlam amyrlam mentioned this pull request Apr 23, 2019
@@ -114,7 +114,7 @@ responsive: true

---

## [#embertimes 📰](https://emberjs.com/blog/tags/newsletter.html)
## [#embertimes 📰](https://blog.emberjs.com/tags/newsletter.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no! ugh

Thanks for catching this, I made a PR to fix this in the template: #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants