Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For Ember Times No. 141: Writeup on Website Porting with Percy #588

Merged
merged 3 commits into from
Mar 27, 2020
Merged

For Ember Times No. 141: Writeup on Website Porting with Percy #588

merged 3 commits into from
Mar 27, 2020

Conversation

jayjayjpg
Copy link
Contributor

What it does

Related Issue(s)

Sources

@jayjayjpg jayjayjpg requested a review from a team March 27, 2020 21:23
@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Mar 27, 2020
chrisrng
chrisrng approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@chrisrng chrisrng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

ijlee2
ijlee2 approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for the write-up! I didn't know guides.emberjs.com wasn't always in Ember. Look forward to learn more by reading Chris' blog post.

@jayjayjpg jayjayjpg merged commit 718d857 into ember-learn:blog/embertimes-141 Mar 27, 2020
@jayjayjpg
Copy link
Contributor Author

🙇‍♀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijlee2 ijlee2 ijlee2 approved these changes

@chrisrng chrisrng chrisrng approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jayjayjpg @chrisrng @ijlee2