Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Covered blog post on classic vs. angle bracket invocation #587

Merged
merged 2 commits into from
Mar 27, 2020
Merged

Covered blog post on classic vs. angle bracket invocation #587

merged 2 commits into from
Mar 27, 2020

Conversation

ijlee2
Copy link
Member

@ijlee2 ijlee2 commented Mar 27, 2020

No description provided.

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Mar 27, 2020
@@ -45,19 +46,19 @@ So be on the look out 👀 for more in this very helpful new series!

---

## [Achieve consistent decorator positioning with a new eslint plugin ↕️](https://github.com/NullVoxPopuli/eslint-plugin-decorator-position)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this section down so that I could group related posts that were about Ember templates.


He also added some extra bonus tips, but no **spoilers** here, head to the [blog post](https://abhilashlr.in/ember-refactor-templates) to check them out!
[@0xADADA](https://github.com/0xadada) and [@dfreeman](https://github.com/dfreeman) did a [deep-dive into classic and angle bracket invocations](https://0xadada.pub/2020/03/20/ember-emplates-classic-vs-angle-bracket-syntaxes/). Please have a look to learn how these invocations handle attributes and arguments differently.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because 0xADADA didn't make their name public, I showed just the GitHub handle for both authors.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good call! 👍

Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great! I left one more small suggestion for a change that was already part of the post previously, but otherwise this should already be good to go. Thank you for another great ✨ writeup for the Ember Times this week 🎉


He also added some extra bonus tips, but no **spoilers** here, head to the [blog post](https://abhilashlr.in/ember-refactor-templates) to check them out!
[@0xADADA](https://github.com/0xadada) and [@dfreeman](https://github.com/dfreeman) did a [deep-dive into classic and angle bracket invocations](https://0xadada.pub/2020/03/20/ember-emplates-classic-vs-angle-bracket-syntaxes/). Please have a look to learn how these invocations handle attributes and arguments differently.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good call! 👍

source/2020-03-27-the-ember-times-issue-141.md Outdated Show resolved Hide resolved
@ijlee2 ijlee2 merged commit 33a8a34 into ember-learn:blog/embertimes-141 Mar 27, 2020
@ijlee2 ijlee2 deleted the blog/embertimes-141 branch March 27, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants