Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog(embertimes#140): add emberconf writeup #574

Merged
merged 2 commits into from
Mar 20, 2020
Merged

blog(embertimes#140): add emberconf writeup #574

merged 2 commits into from
Mar 20, 2020

Conversation

jayjayjpg
Copy link
Contributor

What it does

Related Issue(s)

Sources

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Mar 20, 2020
@jayjayjpg jayjayjpg requested a review from a team March 20, 2020 15:03
hergaiety
hergaiety approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@hergaiety hergaiety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, all links work as expected to the correct place.

@jayjayjpg jayjayjpg merged commit 7abe5d4 into ember-learn:blog/embertimes-140 Mar 20, 2020
@jayjayjpg
Copy link
Contributor Author

Thank you for your review for the Ember Times this week 🙇‍♀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hergaiety hergaiety hergaiety approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayjayjpg @hergaiety