blog(embertimes135): EmberMap Native Decorator #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
reviewed
Feb 11, 2020
ijlee2
reviewed
Feb 11, 2020
|
|
||
| <add your name to author list, top and bottom> | ||
| <add blurb and emoji to "SOME-INTRO-HERE"> | ||
| With Ember 3.10, all the core APIs and surrounding ecosystem libraries can start adopting decorators as per the [stage 1 implementation](https://github.com/tc39/proposal-decorators) which would pave the way for ES classes in Ember. However, the happy path is still to wait until [the Octane release or 3.15](https://blog.emberjs.com/2019/12/20/ember-3-15-released.html) to start using both ES classes and decorators together for all of your Ember app code. |
There was a problem hiding this comment.
I haven't watched the video yet, so in this paragraph, I was a little confused by what you had meant to convey regarding Ember 3.10 versus 3.15.
There was a problem hiding this comment.
they talked about the history – im gonna submit for now since ill be away from laptop lol but feel free to rewrite as needed :) thanks for the review!
ijlee2
approved these changes
Feb 11, 2020
Co-Authored-By: Isaac Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.