Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Covered RFCs 566, 567, 569, and 577 on improving autotracking (Ember Times 131) #496

Merged
merged 8 commits into from
Jan 17, 2020
Merged

Covered RFCs 566, 567, 569, and 577 on improving autotracking (Ember Times 131) #496

merged 8 commits into from
Jan 17, 2020

Conversation

ijlee2
Copy link
Member

@ijlee2 ijlee2 commented Jan 17, 2020

No description provided.

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Jan 17, 2020
amyrlam
amyrlam approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 appreciate you taking on the massive wall of rfc's!

MinThaMie
MinThaMie requested changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got some comments :)

source/2020-01-17-the-ember-times-issue-131.md Outdated Show resolved Hide resolved
source/2020-01-17-the-ember-times-issue-131.md Outdated Show resolved Hide resolved
source/2020-01-17-the-ember-times-issue-131.md Outdated Show resolved Hide resolved
@ijlee2
Copy link
Member Author

ijlee2 commented Jan 17, 2020

Thank you both for reviewing!

@ijlee2 ijlee2 requested a review from MinThaMie January 17, 2020 13:20
jayjayjpg
jayjayjpg approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great! I left one more suggestion to make the change pass on CI, but otherwise this seems to be good to go! Thank you for another ✨ writeup for The Ember Times this week!

source/2020-01-17-the-ember-times-issue-131.md Outdated Show resolved Hide resolved
@ijlee2 ijlee2 merged commit 0b536ae into ember-learn:blog/embertimes-131 Jan 17, 2020
@ijlee2 ijlee2 deleted the blog/embertimes-131 branch January 17, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayjayjpg jayjayjpg jayjayjpg approved these changes

@amyrlam amyrlam amyrlam approved these changes

@MinThaMie MinThaMie Awaiting requested review from MinThaMie

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ijlee2 @amyrlam @MinThaMie @jayjayjpg