Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Intro and Quotes to Octane Special #484

Merged
merged 4 commits into from
Jan 10, 2020
Merged

Add Intro and Quotes to Octane Special #484

merged 4 commits into from
Jan 10, 2020

Conversation

MinThaMie
Copy link
Contributor

I've added a tiny intro and some quotes sprinkled around that seemed to match the content of that part of the times

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Jan 10, 2020
@MinThaMie MinThaMie requested a review from a team January 10, 2020 20:52
@MinThaMie MinThaMie self-assigned this Jan 10, 2020
@MinThaMie MinThaMie changed the title Update 2020-01-10-the-ember-times-issue-130.md Add Intro and Quotes to Octane Special Jan 10, 2020
jayjayjpg
jayjayjpg approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great! I left two more small suggestions on the quotes and I really like the new version of the intro. As always: thank you for another great ✨ writeup for the Ember Times 🌈

source/2020-01-10-the-ember-times-issue-130.md Outdated Show resolved Hide resolved
source/2020-01-10-the-ember-times-issue-130.md Outdated Show resolved Hide resolved
@jayjayjpg jayjayjpg merged commit ae4c0c3 into blog/embertimes-octane-special Jan 10, 2020
@jayjayjpg jayjayjpg deleted the intro_and_quotes branch January 10, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisrng chrisrng chrisrng approved these changes

@jayjayjpg jayjayjpg jayjayjpg approved these changes

Assignees

@MinThaMie MinThaMie

Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MinThaMie @chrisrng @jayjayjpg