Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Octane at EmberConf #479

Merged
merged 7 commits into from
Jan 10, 2020
Merged

Octane at EmberConf #479

merged 7 commits into from
Jan 10, 2020

Conversation

MinThaMie
Copy link
Contributor

What it does

Related Issue(s)

Sources

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Jan 8, 2020
@MinThaMie MinThaMie self-assigned this Jan 8, 2020
@MinThaMie MinThaMie requested a review from a team January 8, 2020 18:54
ijlee2
ijlee2 approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anne, thanks for covering the EmberConf event. I made a few suggestions; will you have a look?

I'm looking forward to hear your talk soon!

source/2020-01-10-the-ember-times-issue-130.md Outdated Show resolved Hide resolved
source/2020-01-10-the-ember-times-issue-130.md Outdated Show resolved Hide resolved
source/2020-01-10-the-ember-times-issue-130.md Outdated Show resolved Hide resolved
jayjayjpg
jayjayjpg approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great! I agree with the suggestions that @ijlee2 already made, but apart from that this shoul be already good to go - thank you for this ✨ writeup for the Octane special!

@ijlee2
Copy link
Member

ijlee2 commented Jan 10, 2020

@MinThaMie I'll go ahead and merge this, so that I have the latest changes for working on my piece.

@ijlee2 ijlee2 merged commit 3c6c354 into blog/embertimes-octane-special Jan 10, 2020
@ijlee2 ijlee2 deleted the octaneAtEmberConf branch January 10, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijlee2 ijlee2 ijlee2 approved these changes

@jayjayjpg jayjayjpg jayjayjpg approved these changes

Assignees

@MinThaMie MinThaMie

Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MinThaMie @ijlee2 @jayjayjpg