Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog(embertimes129): 3 New RFCs #441

Merged
merged 4 commits into from
Dec 18, 2019
Merged

Conversation

chrisrng
Copy link
Member

No description provided.

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Dec 17, 2019
@jayjayjpg jayjayjpg requested a review from a team December 17, 2019 23:43
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great and I left a few more suggestions - lmk what you think! Otherwise, thank you for another great ✨ (and on top of that super early!) writeup this week 🌈

source/2019-12-20-the-ember-times-issue-129.md Outdated Show resolved Hide resolved
source/2019-12-20-the-ember-times-issue-129.md Outdated Show resolved Hide resolved
source/2019-12-20-the-ember-times-issue-129.md Outdated Show resolved Hide resolved
@chrisrng
Copy link
Member Author

@jessica-jordan omg thanks! I totally feel asleep on the wheel (feeling a bit under the weather) and forgot to code all the template helpers

@jayjayjpg jayjayjpg merged commit dcce173 into blog/embertimes-129 Dec 18, 2019
@jayjayjpg jayjayjpg deleted the chrisrng-patch-1 branch December 18, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants