Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ember-autofocus-modifier writeup #440

Merged
merged 4 commits into from
Dec 17, 2019
Merged

Add ember-autofocus-modifier writeup #440

merged 4 commits into from
Dec 17, 2019

Conversation

amyrlam
Copy link
Member

@amyrlam amyrlam commented Dec 17, 2019

👉 I am traveling this week so Jessica will kindly be Goodbits-ing this Friday!

Related Issue(s)

#434

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Dec 17, 2019
@amyrlam amyrlam requested a review from a team December 17, 2019 05:57
@amyrlam amyrlam force-pushed the blog/embertimes-129 branch from 6ac53d5 to d621bf5 Compare December 17, 2019 05:59
@amyrlam
Copy link
Member Author

amyrlam commented Dec 17, 2019 •
edited
Loading

ignore the ci failure here, i just rebased #434 to include #439 (aka can be merged into blog/embertimes-129 if failing)

jayjayjpg
jayjayjpg approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great! I left one more small suggestion, otherwise this is ✨ Thank you for the great (and still super-early!) writeup this week and happy holidays 🎄

source/2019-12-20-the-ember-times-issue-129.md Outdated Show resolved Hide resolved
@amyrlam
Copy link
Member Author

amyrlam commented Dec 17, 2019

i will merge this in, feel free to nix if the issue changes! but maybe could work for special as well, toward the end?

@amyrlam amyrlam merged commit 61928c6 into blog/embertimes-129 Dec 17, 2019
@amyrlam amyrlam deleted the amy/embertimes-129 branch December 17, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayjayjpg jayjayjpg jayjayjpg approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amyrlam @jayjayjpg