-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog(embertimes128): accessible ember sortable #423
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyrlam
force-pushed
the
chrisrng-patch-1
branch
from
December 11, 2019 06:34
62ec656
to
b4d061a
Compare
amyrlam
force-pushed
the
blog/embertimes-128
branch
from
December 11, 2019 06:38
6e36231
to
cc17a43
Compare
amyrlam
approved these changes
Dec 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thank you! 👍
left some optional suggestions, hopefully not too confusing
there was a CI error, so ended up rebasing the parent blog branch
Co-Authored-By: Amy Lam <[email protected]>
Co-Authored-By: Amy Lam <[email protected]>
Co-Authored-By: Amy Lam <[email protected]>
Co-Authored-By: Amy Lam <[email protected]>
MelSumner
reviewed
Dec 11, 2019
Co-Authored-By: Melanie Sumner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.