Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog(embertimes128): accessible ember sortable #423

Merged
merged 11 commits into from
Dec 11, 2019

Conversation

chrisrng
Copy link
Member

No description provided.

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Dec 10, 2019
Copy link
Member

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thank you! 👍

left some optional suggestions, hopefully not too confusing

there was a CI error, so ended up rebasing the parent blog branch

source/2019-12-13-the-ember-times-issue-128.md Outdated Show resolved Hide resolved
source/2019-12-13-the-ember-times-issue-128.md Outdated Show resolved Hide resolved
source/2019-12-13-the-ember-times-issue-128.md Outdated Show resolved Hide resolved
source/2019-12-13-the-ember-times-issue-128.md Outdated Show resolved Hide resolved
source/2019-12-13-the-ember-times-issue-128.md Outdated Show resolved Hide resolved
source/2019-12-13-the-ember-times-issue-128.md Outdated Show resolved Hide resolved
@chrisrng chrisrng merged commit e7ad634 into blog/embertimes-128 Dec 11, 2019
@chrisrng chrisrng deleted the chrisrng-patch-1 branch December 11, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants