Clear stale search results when version is changed #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! Is this ready for review? I suspect that maybe this feature got a bug when we converted some components to use tracked instead of observers and computed properties. It will be great to have it working! |
|
Oops, I have some lint issues to fix, but the general approach is ready for feedback |
MinThaMie
approved these changes
Jul 25, 2023
locks
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #872.
This approach replaces the stale search results just in time whenever the search results dropdown is about to display.
By doing it this way we don't have to clear the user's search term whenever they change versions. They can pick up right where they left off, but with fresh search results.
ember-api-docs.mp4