Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ember-cli-fastboot rc1 #222

Closed
mschinis opened this issue May 24, 2017 · 0 comments
Closed

Support ember-cli-fastboot rc1 #222

mschinis opened this issue May 24, 2017 · 0 comments

Comments

@mschinis
Copy link
Contributor

mschinis commented May 24, 2017 •
edited
Loading

Fastboot rc1 released three days ago made a couple of breaking changes, one of them is using (instance-)initialisers/browser structure.

Ember serve fails with:

FastBoot build no longer supports /.../ember-learn/ember-api-docs/node_modules/ember-cli-head/app/(instance-)?initializers/browser structure. 
Please refer to www.ember-fastboot.com for a migration path.

We should either:

  1. do a quick temporary solution to set ember-cli-fastboot dependency to be exact 1.0.0-beta.16 (last known working beta version with this project)
  2. Update ember-cli-head and ember-api-docs to not use these initializers.

Option number 2 is depends on ember-fastboot/ember-cli-head#21
@mschinis mschinis changed the title Support fastboot rc1 Support ember-cli-fastboot rc1 May 24, 2017
@mschinis mschinis mentioned this issue May 24, 2017
Merged
@sivakumar-kailasam sivakumar-kailasam mentioned this issue Jun 10, 2017
Merged
Gaurav0 pushed a commit to Gaurav0/ember-api-docs that referenced this issue Sep 16, 2019
@LalithaRajanala
Added examples for index routes (ember-learn#222)
c598af5 
* Update defining-your-routes.md

* Updated file after addressing review comments

* Adjust example ordering and fix typos

* fix dynamic route example

* fix path in router example

* edit route path in example

* small typo/wording fixes

* Edits suggested by cah-danmonroe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mschinis