Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add travis-ci-support ember-cli v5 deprecation #1338

Merged
merged 4 commits into from
Oct 22, 2023
Merged

Conversation

locks
Copy link
Contributor

@locks locks commented Aug 28, 2023

No description provided.

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for ember-deprecations ready!

Name Link
🔨 Latest commit 5afd1d5
🔍 Latest deploy log https://app.netlify.com/sites/ember-deprecations/deploys/6532a5a75a2f0b0008711e11
😎 Deploy Preview https://deploy-preview-1338--ember-deprecations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@locks locks force-pushed the ec-v5-travis-ci-support branch from 629ac1c to 34d392e Compare August 29, 2023 16:21
@locks locks force-pushed the ec-v5-travis-ci-support branch from 34d392e to 1538ea0 Compare August 30, 2023 10:35
content/ember-cli/v5/travis-ci-support.md Outdated Show resolved Hide resolved
@locks locks changed the title add travis-ci-support ember-cli v5 deprecation [draft] add travis-ci-support ember-cli v5 deprecation Aug 30, 2023
@ef4
Copy link
Contributor

ef4 commented Oct 13, 2023

The RFC for this is now Ready to Release, so this can be released and should be reported back on emberjs/rfcs#978

@kategengler kategengler force-pushed the ec-v5-travis-ci-support branch from 1538ea0 to 8de1e0d Compare October 20, 2023 15:31
@kategengler kategengler changed the title [draft] add travis-ci-support ember-cli v5 deprecation add travis-ci-support ember-cli v5 deprecation Oct 20, 2023
@kategengler
Copy link
Contributor

@ember-learn/learning-core-team Who can approve Percy? This should be ready to go.

@jenweber jenweber merged commit 8a74fcc into main Oct 22, 2023
2 checks passed
@jenweber jenweber deleted the ec-v5-travis-ci-support branch October 22, 2023 14:01
@jenweber
Copy link
Contributor

@kategengler approved and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants