Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate implict route model #1334

Merged
merged 4 commits into from
Jul 28, 2023
Merged

Deprecate implict route model #1334

merged 4 commits into from
Jul 28, 2023

Conversation

wagenet
Copy link
Contributor

@wagenet wagenet commented Jun 29, 2023 •
edited
Loading

@netlify
Copy link

netlify bot commented Jun 29, 2023 •
edited
Loading

✅ Deploy Preview for ember-deprecations ready!

Name Link
🔨 Latest commit b1d4e23
🔍 Latest deploy log https://app.netlify.com/sites/ember-deprecations/deploys/64bfa35267d36a0008d51657
😎 Deploy Preview https://deploy-preview-1334--ember-deprecations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wagenet wagenet mentioned this pull request Jun 29, 2023
Merged
9 tasks
@wagenet wagenet force-pushed the deprecate-implicit-route-model branch from b80c3f3 to e0b755f Compare July 20, 2023 19:22
@wagenet wagenet marked this pull request as ready for review July 20, 2023 19:32
@wagenet wagenet mentioned this pull request Jul 20, 2023
Merged
@wagenet wagenet force-pushed the deprecate-implicit-route-model branch from e0b755f to 665889b Compare July 20, 2023 19:44
@MinThaMie MinThaMie force-pushed the deprecate-implicit-route-model branch from 4063443 to b1d4e23 Compare July 25, 2023 10:26
MinThaMie
MinThaMie approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@MinThaMie MinThaMie merged commit f671e3c into main Jul 28, 2023
@MinThaMie MinThaMie deleted the deprecate-implicit-route-model branch July 28, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinThaMie MinThaMie MinThaMie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wagenet @MinThaMie