Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Add all 4.x ember-data deprecation pages #1319

Merged

Conversation

bartocc
Copy link
Contributor

@bartocc bartocc commented Apr 17, 2023

These pages are empty for the time being

@netlify
Copy link

netlify bot commented Apr 17, 2023

Deploy Preview for ember-deprecations ready!

Name Link
🔨 Latest commit defcb86
🔍 Latest deploy log https://app.netlify.com/sites/ember-deprecations/deploys/648db0655a00f50008dcee79
😎 Deploy Preview https://deploy-preview-1319--ember-deprecations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bartocc bartocc force-pushed the ember-data-4-x-deprecation-guides branch 2 times, most recently from fede3f0 to 52295ea Compare April 17, 2023 09:42
These pages are empty for the time being
@jenweber jenweber force-pushed the ember-data-4-x-deprecation-guides branch from 52295ea to a03ec7e Compare June 16, 2023 19:55
@jenweber
Copy link
Contributor

Thanks for getting this started back in the day! This helps with resolving one of the release blockers for Ember 5. #1330 so I rebased it to give any volunteers an up-to-date start.

- ember data content files must have ember-data in the name
@jaredgalanis jaredgalanis marked this pull request as ready for review June 17, 2023 13:12
@jaredgalanis jaredgalanis requested a review from jenweber June 17, 2023 13:12
@jaredgalanis jaredgalanis merged commit dd2d7fb into ember-learn:main Jun 17, 2023
@jenweber
Copy link
Contributor

yaaaay thank you!

@bartocc
Copy link
Contributor Author

bartocc commented Jun 19, 2023

Awesome, thx @jenweber for the rebase and @jaredgalanis for all the content 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants