Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/automation #9

Merged
merged 8 commits into from
Oct 4, 2018
Merged

Conversation

aklkv
Copy link
Contributor

@aklkv aklkv commented Oct 3, 2018

@jenweber As per our discussion this PR represents the first step to adding more tests and linting.
In this PR:

  • Upgraded all packages to latest versions (since there are mostly linting packages nothing should break)
  • Added repository property to package.json
  • Set up for markdown linting using popular tool remark.js
  • Added mark down linting presets (this is up for discussion I just though this would be most appropriate once)
  • Started setting up travis to run tests and linting (it is expected for build to break as I have not updated all files according to new linting rules I will do so we confirm presets)
  • Added editorconfig with some common configurations (this is also up for discussion)

Let me know what you thing about this changes.

@jenweber jenweber merged commit 5f38dfa into ember-learn:master Oct 4, 2018
@jenweber
Copy link
Contributor

jenweber commented Oct 4, 2018

I love it! Merged. Thank you so much.

@jenweber
Copy link
Contributor

jenweber commented Oct 4, 2018

Good news! Travis config works like a charm and there are only a few linting things that need to be fixed (missing images). CI is now in place for PRs moving forward.

@aklkv aklkv deleted the feature/automation branch October 4, 2018 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants