Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port over Windows support #6

Merged
merged 3 commits into from
Oct 4, 2018
Merged

Port over Windows support #6

merged 3 commits into from
Oct 4, 2018

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Oct 2, 2018 •
edited
Loading

For #3

Unedited except to make sure things work. Only new text is in index.md.

Update: Now edited in response to comments.

@Gaurav0 Gaurav0 mentioned this pull request Oct 2, 2018
Closed
32 tasks
jayjayjpg
jayjayjpg reviewed Oct 2, 2018
View reviewed changes
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this detailed writeup! I left two minor few comments / questions, but otherwise this seems good to me. I'll take another look locally to make sure everything runs fine as well

guides/reference/windows.md Outdated Show resolved Hide resolved
guides/reference/windows.md Outdated Show resolved Hide resolved
sandstrom
sandstrom reviewed Oct 3, 2018
View reviewed changes
guides/reference/windows.md Outdated Show resolved Hide resolved
guides/reference/windows.md Outdated Show resolved Hide resolved
@jenweber jenweber merged commit e7aa080 into ember-learn:master Oct 4, 2018
@jenweber
Copy link
Contributor

jenweber commented Oct 4, 2018

Hooray, thanks for the PR and the revisions! And to everyone for reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayjayjpg jayjayjpg jayjayjpg left review comments

@chriskrycho chriskrycho chriskrycho left review comments

@sandstrom sandstrom sandstrom left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gaurav0 @jenweber @sandstrom @chriskrycho @jayjayjpg