Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3 blueprints #38

Merged
merged 6 commits into from
Nov 25, 2018
Merged

#3 blueprints #38

merged 6 commits into from
Nov 25, 2018

Conversation

maxwondercorn
Copy link
Contributor

This covers the blueprints section from the old guides.

In the old guides, blueprints are introduced before addons. In the new guides they're after the addon introduction. Probably need to link to blueprints in the advanced addon example(s).

I believe I followed the style guides, but I'm sure I missed something. Review, review and review some more..

  • verified examples and code, fixed/updated where necessary, pr to fix API docs (pr API documentation - incorrect example locals hook ember-cli/ember-cli#8200)
  • modified/simplified docs for more clarity - may be wordy...
  • documented blueprint help descriptions and options
  • documented fileMapTokens hook object - a better location may be API docs
  • separated out pods blueprints
  • added example in pods to show how to handle template files

The object passed into hooks needs documenting in the API docs (not in either old or new guides)

@jenweber
Copy link
Contributor

@maxwondercorn thanks for this section! It looks like it was a lot of work! I did some proofreading and the main thing needed was backticks around some method names.

I think we could work to make some of the wording simpler, but that's something we can do in later PRs.

I will add hooks and destroy to our linter so that it doesn't cause a CI failure.

@jenweber jenweber merged commit d58141c into ember-learn:master Nov 25, 2018
@maxwondercorn maxwondercorn deleted the blueprints branch November 25, 2018 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants