Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade guidemaker deps #316

Merged

Conversation

IgnaceMaes
Copy link
Member

@IgnaceMaes IgnaceMaes commented Jun 29, 2024

This PR makes the CLI guides in line with guides-source in terms of setup.

  • Upgrades Fastboot and Prember
  • Configures ember-showdown-shiki
  • Upgrades Node used on Netlify
  • Upgrades guidemaker-ember-template
  • Align code styling with guides-source

Copy link

netlify bot commented Jun 29, 2024

Deploy Preview for ember-cli-guides ready!

Name Link
🔨 Latest commit 1b3a899
🔍 Latest deploy log https://app.netlify.com/sites/ember-cli-guides/deploys/66830111aef075000875d7b6
😎 Deploy Preview https://deploy-preview-316--ember-cli-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed during Learning meeting 1st of July;
We would love for it to not have custom css. It looks also good without this :)

@IgnaceMaes IgnaceMaes force-pushed the upgrade-guidemaker-ember-template branch from 474fb1a to 1b3a899 Compare July 1, 2024 19:18
@IgnaceMaes
Copy link
Member Author

IgnaceMaes commented Jul 1, 2024

Reverted the custom CSS for the time being.

The custom styling is currently in guides-source, which is also not the correct place. We should move that to guidemaker-ember-template so it's aligned across all doc sites. But that should be a separate PR to unblock this.

@IgnaceMaes IgnaceMaes requested a review from MinThaMie July 1, 2024 19:21
Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :) I think we could also move the CSS to style guide if that makes sense :)

@MinThaMie MinThaMie merged commit 5741a28 into ember-learn:main Jul 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants