-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port over upgrading #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some more specific nits inline.
Overall, I think that codemods would benefit from their own section, or perhaps making the headers different use cases instead of examples. Set up a scenario, from and to versions, run the codemods, see what happens. Can even use Super Rentals or similar. For codemods, something like "Updating your code automatically", where you briefly explain how it works and potential pitfalls (conflicts, etc)?
(This should be run after running the normal update shown above, and after you've resolved any conflicts.) | ||
|
||
``` | ||
ember-cli-update --run-codemods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this will not work as you are expected if you don't specify the --from
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the instructions straight from Kelly's README. I have ran it this way before and it worked without the --from
.
guides/basic-use/upgrading.md
Outdated
ember-cli-update --run-codemods | ||
``` | ||
|
||
Codemods are tools that assist large-scale codebase refactoring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this should be explained at the head.
Awesome, thank you @DanMonroe! 🎉 I will add a new item to the list for addons upgrading. My thought is to draft some new content around how to know if an addon is compatible with your app version. I had a hard time with this as a new dev. |
Initial commit of porting the app upgrade process. I've included an example and a hint on how to recover from a bad upgrade.
What do you want to include for upgrading an addon?