-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make addon more idiomatic at the expense of making it 2.10+ & fastboot 1.0rc+ #32
Conversation
Might as well move |
@kratiahuja I don't follow. That is precisely what I did. |
Super sorry :( those changes showed up very small in the diff so I got confused. This LGTM. |
@cibernox can you please explain the rationale for these changes? A bit of work went into #21 to not make any breaking changes, so it now runs with beta and rc version of FastBoot as well as those older Ember versions. I understand the required code became quite a bit confusing when looking at it, but as this addon is probably used by most FastBoot apps, I think a higher degree of compatibility would make sense. At least until we feel safe to drop support for older version, say when FastBoot 1.0 stable has been released and most other addons have been migrated (still a long way, see ember-fastboot/ember-cli-fastboot#387). Then the changes here make absolutely sense to me! |
LGTM. @simonihmig are you ok with dropping pre-1.0 Fastboot support with a 0.3 version bump? |
@ronco Sure, if it's ok for you, so it is for me! :) |
agreed, I like this direction |
Added a note on the readme explaining that.