Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use preconcatTree hook for filterInitializers #24

Closed

Conversation

simonihmig
Copy link
Contributor

When upgrading an app to ember-cli 2.13, the FastBoot support of this addon stopped working. I noticed it used the treeForApp hook instead of preconcatTree to apply the filterInitializers. Changing that fixed the problem.

This is a quick fix until #21 lands...

@josemarluedke
Copy link
Contributor

I tried this branch using Ember CLI 2.14.0-beta.1 and it doesn't work, not sure if that hook was removed from Ember CLI or not.

@simonihmig
Copy link
Contributor Author

simonihmig commented May 7, 2017

@josemarluedke thanks for testing. As https://github.com/ronco/fastboot-filter-initializers does not mention anything special, I assumed this would work. But it seems ember-cli does not provide this hook, this comes form ember-cli-fastboot monkey patching it: https://github.com/ember-fastboot/ember-cli-fastboot/blob/e890b45f474fb3a05c5d5b0203daa2cb63447dcb/lib/ext/patch-ember-app.js#L40. So while this should work in a FastBoot enabled (pre 1.0) app, I don't see how that proposed setup using preconcatTree can work in a non-FastBoot app. This might be the problem you encountered!? (or what exactly did you see?)

Will try to find a better solution, or better first find out why this stopped working for me with ember-cli 2.13...

@simonihmig
Copy link
Contributor Author

Closing this as its is superseded by #21

@simonihmig simonihmig closed this Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants