Move some failing tests from pre-built fixtures to scenario-tester #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 29, 2023
mansona
force-pushed
the
scenario-tester
branch
2 times, most recently
from
05f0715
to
6e76ab4
Compare
mansona
force-pushed
the
scenario-tester
branch
3 times, most recently
from
5e1c509
to
20d7946
Compare
mansona
changed the title
mansona
force-pushed
the
scenario-tester
branch
from
20d7946
to
ab5854b
Compare
mansona
force-pushed
the
scenario-tester
branch
3 times, most recently
from
1e5d8cb
to
ba423cc
Compare
mansona
changed the title
mansona
force-pushed
the
scenario-tester
branch
2 times, most recently
from
f9f2188
to
c955b68
Compare
|
Very excited for this. Anything community members can do to help it along?
|
mansona
force-pushed
the
scenario-tester
branch
from
c955b68
to
f5c87f8
Compare
mansona
force-pushed
the
scenario-tester
branch
from
c4cfca1
to
418c133
Compare
mansona
force-pushed
the
scenario-tester
branch
from
521f4fe
to
74b5508
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI has been very broken lately 🙈 and most of these errors have been exceedingly hard to understand because a lot of our tests rely on ages-old fixtures that are essentially pre-built ember apps. There is a better way to get this sort of "fixture" test and we've been using it in embroider and ember-auto-import for a very long time, it's scenario-tester
This PR sets up the scenario-tester infrastructure and moves some of the failing tests over to it. Eventually we would want to move all the fixture tests over but I'm doing the absolute minimum to get CI passing right now 👍