-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform tests to 'setup-test' syntax #90
Merged
rwjblue
merged 14 commits into
ember-engines:master
from
evanfarina:transform_tests_setup_test_format
Jan 24, 2020
Merged
Transform tests to 'setup-test' syntax #90
rwjblue
merged 14 commits into
ember-engines:master
from
evanfarina:transform_tests_setup_test_format
Jan 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
requested changes
Jan 8, 2020
…-maybe-import-regenerator as a dev dep.
rwjblue
approved these changes
Jan 8, 2020
@rwjblue I've spent the last day digging into the travis failures and what I've found is this:
|
rwjblue
reviewed
Jan 9, 2020
Mind rebasing to get the CI fixes? |
…-maybe-import-regenerator as a dev dep.
Rebased. Had to make some adjustments to keep travis (saucie) happy. |
rwjblue
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to running the ember-qunit-codemode a few changes were necessary:
autoboot=false
toenvironment.js
. This ensures that duplicate apps are not created when running tests. I searched through a few others apps and read through a handful of issues on github before coming to the conclusion that this was an accepted best practice. If anyone feels that there is a more sustainable to solution to multiple container divs being created when running tests please let me know.includePolyfill
to ember-cli-build due to aregeneratorRuntime is not defined
error being thrown.tests/test-helper.js