Add option to ignore specific files from being added to the manifest #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upon further thought, for the ember-engines use case, we'll likely need to support either suffix matching or regular expressions. I tend to think the latter is better, so I'll be updating this accordingly. |
rwjblue
reviewed
Sep 10, 2017
| it('can ignore specific files', function() { | ||
| return verifyAssetManifest('full-minus-ignored-files', { | ||
| prepend: '/bundles', | ||
| filesToIgnore: [ 'blog/assets/engine.css', 'chat/assets/engine.js' ] |
There was a problem hiding this comment.
Minor quibble about the naming, we have a similar concept in broccoli-funnel land and call it exclude. Thoughts?
There was a problem hiding this comment.
I originally had this as ignore, but changed it because there may be a use case in the future where we want an entire "bundle" ignored, in which case we may want some added specificity. Also, I prefer the explicitness. That said, I don't feel super strongly about it either way.
rwjblue
approved these changes
Sep 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been several use cases presented for this feature, most notably: ember-engines/ember-engines#444 (comment).