Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore chained class definitions #179

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Ignore chained class definitions #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions transforms/ember-object/__testfixtures__/chained-class-definition.input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import EmberObject from '@ember/object';

export default EmberObject.extend({}).reopenClass({});
3 changes: 3 additions & 0 deletions transforms/ember-object/__testfixtures__/chained-class-definition.output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import EmberObject from '@ember/object';

export default EmberObject.extend({}).reopenClass({});
5 changes: 5 additions & 0 deletions transforms/helpers/parse-helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,11 @@ function replaceEmberObjectExpressions(j, root, filePath, options = {}) {
);

const errors = hasValidProps(j, eoProps, options);

if (get(eoCallExpression, 'parentPath.value.type') === 'MemberExpression') {
errors.push('class has chained definition (e.g. EmberObject.extend().reopenClass();');
}

if (errors.length) {
logger.warn(`[${filePath}]: FAILURE \nValidation errors: \n\t${errors.join('\n\t')}`);
return;
Expand Down