Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes @className and @attribute in favor of @classNameBindings and @attributeBindings #176

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

pzuraq
Copy link
Collaborator

@pzuraq pzuraq commented Aug 14, 2019

Removes @classname and @Attribute decorators in favor of
@classNameBindings and @attributeBindings class decorators

Removes @classname and @Attribute decorators in favor of
@classNameBindings and @attributeBindings class decorators
@pzuraq pzuraq merged commit ebe7c88 into master Aug 14, 2019
@pzuraq pzuraq deleted the remove-class-name-and-attribute branch August 14, 2019 22:54
@rwjblue rwjblue changed the title [FEAT] Removes @className and @attribute Removes @className and @attribute in favor of @classNameBindings and @attributeBindings Aug 20, 2019
@rwjblue rwjblue added the enhancement New feature or request label Aug 20, 2019
@omairvaiyani
Copy link

Is this a breaking change or can we still use @className and @attribute?

@pzuraq
Copy link
Collaborator Author

pzuraq commented Aug 22, 2019

ember-decorators includes both @className and @attribute still, this is just an easier target for codemodding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants