-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Replace dyfactor with puppeteer #118
Conversation
4bb1a49
to
f0c5074
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really great, thanks for working on this!
Can you update the top level package.json
(the codemod's own) to drop Node 6 and 11 support from the engines
field? I noticed we changed CI to use Node 8, so we should make sure to update engines
and "bump majors" to 0.2.0.
@@ -0,0 +1,20 @@ | |||
# EditorConfig helps developers define and maintain consistent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on adding ember-cli
as a devDep and generating this dynamically? The vast majority of these files do not need to be in the repo, we could generate a new app and then only talk about the "diff" between what we added.
Anyways, I think this is a good follow up PR, we should not block landing on this...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about this, and would like to. My main concerns are properly generating the output
application, and the ability to add arbitrary test scenarios in the integration app. I'd like to write more complex scenarios that involve telemetry out in the integration test. So, we'd need some way to generate most of the app, and then copy the app folder over.
Probably we could just do that, just check in the app folders and generate/compare them. I'll work on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pzuraq - Let's make an issue to track that, I'd like to circle back around and this is good enough for now...
Avoids having to duplicate the cache key in multiple places.
Updated to address feedback. Should be "good to go"... |
This PR updates the codemod in the following ways:
It also updates the command users use to run the codemod. They no longer have to provide the name of the codemod as the first argument, and should instead provide the URL to gather telemetry at: