heimdall stuff is not stripped correctly.

[stefanpenner]

• strange thing where the entire heimdall thing came with unexpectedly (not sure how this happened)

Uncaught TypeError: Cannot read property 'registerMonitor' of undefined

• var heimdall = global.heimdall; still remains

[stefanpenner]

^ was a quick fix, investigating now why it was giving me issues.

[stefanpenner]

im not sure how the first example happened, I can't reproduce it myself

[stefanpenner]

I think @runspired is working on some heimdal ember-cli add-on stuff. I'll keep this disable for abit, and we can revisit soon.

[runspired]

Confirm, once we have shipped a v2 to v3 compat shim for heimdall the plan is to create ember-heimdall for enabling global config of what gets stripped etc.

[rwjblue]

the plan is to create ember-heimdall for enabling global config of what gets stripped etc.

Lets have a quick chat about this? I just want to make sure that I'm on the same page, as I am actively working on refactors to ember-cli's JS preprocessing system (e.g. to land babel@6 and utilize the new project.targets system)...

[runspired]

@rwjblue sounds good, I'll ping you on Slack RE this.

[shelah]

@stefanpenner: I'm using your [email protected] so I'm not seeing that error in loader, but am seeing this heimdall error in [email protected]. The error is, "Cannot read property 'heimdall' of undefined", thrown from ember-data.js, line 17:

var loader, define, requireModule, require, requirejs;

(function (global) {
  'use strict';

  var heimdall = global.heimdall;

I will say that when I installed ember-data via ember install ember-data, I got this error when I tried to run ember s:

The Broccoli Plugin: [SourceMapConcat: Concat: Vendor /assets/vendor.js] failed with:
Error: ENOENT: no such file or directory, open '/Users/myaccount/Documents/git/myproject/ember/tmp/source_map_concat-input_base_path-f186pNbr.tmp/bower_components/ember-data/ember-data.js'

and I got past that by installing ember-data on bower too, so that in my package.json file I have

"devDependencies": {
  ...
  "ember-cli": "^2.11.1",
  ...
  "ember-data": "2.12.0",
  ...
}

and in my bower.json file I have

"dependencies": {
    "ember": "^2.11.3",
    ...
    "ember-data": "2.12.0",
    ...
}

Naturally I have the warnings about both being installed but it's the only way I was able to get past the ember-data missing in bower error.

So should I be installing a different version of ember-data? Or is something else the problem?

[stefanpenner]

If you have an issue with ember data please report it there. So we can track/debug/diagnose it quickly :)