Skip to content
This repository has been archived by the owner on Nov 14, 2018. It is now read-only.

Issue with doubble dots in dir names #8

Open
jcsrb opened this issue Aug 31, 2017 · 5 comments
Open

Issue with doubble dots in dir names #8

jcsrb opened this issue Aug 31, 2017 · 5 comments

Comments

@jcsrb
Copy link

jcsrb commented Aug 31, 2017

For reasons beyond the scope of this ticket my project uses dir names that include .. and therefore path like /home/code/test/compare/master...jcsrb are possible and the way this module detects if the path is relative https://github.com/ember-cli/exists-sync/blob/master/index.js#L18 gives a false positive and causes broccoli-funnel which uses this module to fail

Preparing PR with failing test , will add ASAP

@stefanpenner
Copy link
Contributor

This project was created, because for a short term fs.existsSync was deprecated. That was changed, and it is not deprecated. So maybe in this project we should simply delegate back to fs.existsSync and call it a day.

@stefanpenner
Copy link
Contributor

stefanpenner commented Aug 31, 2017

broccolijs/broccoli-funnel#100 can just use fs.existSync directly now

@jcsrb
Copy link
Author

jcsrb commented Aug 31, 2017

thanks for the incredible fast response will switch that version of broccoli-funnel

@stefanpenner
Copy link
Contributor

broccolijs/broccoli-funnel#100 merged and released as v2.0.1

@stefanpenner
Copy link
Contributor

I think we should still consider: #8 (comment) here, thoughts?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants