Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URL to rule documentation to the metadata #208

Merged
merged 1 commit into from
May 14, 2018

Conversation

Arcanemagus
Copy link
Contributor

ESLint v4.15.0 added an official location for rules to store a URL to their documentation in the rule metadata in eslint/eslint#9788. This adds the URL to all the existing rules so anything consuming them can
know where their documentation is without having to resort to external packages to guess.

ESLint v4.15.0 added an official location for rules to store a URL to
their documentation in the rule metadata in eslint/eslint#9788. This
adds the URL to all the existing rules so anything consuming them can
know where their documentation is without having to resort to external
packages to guess.
@Arcanemagus
Copy link
Contributor Author

Hmmm, build syntax errors are in files that weren't touched by this PR, looking into it though...

@Arcanemagus
Copy link
Contributor Author

npm run test:coverage works locally using the same version of Node.js that is failing in the CI, as well as in the older versions of Node.js in the other builds. I'm happy to make any changes needed but as the error is listing as in a file not touched here it looks like something is wrong with the build.

Let me know if there is anything you want me to do here!

@rwjblue
Copy link
Member

rwjblue commented Jan 8, 2018

Restarted CI job, let’s see if it resolves itself...

@rwjblue rwjblue merged commit a37c371 into ember-cli:master May 14, 2018
@rwjblue
Copy link
Member

rwjblue commented May 14, 2018

Awesome, thank you!!

@Arcanemagus Arcanemagus deleted the rules-docs-url branch May 14, 2018 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants