Port code to ember-rfc176-data new format #142

Serabe · 2017-09-18T22:38:44Z

This PR adapts the code to the new format in
ember-cli/ember-rfc176-data#37

This also removes a line testing an old shims not ported to new format.

Turbo87 · 2017-09-19T12:38:39Z

This also removes a line testing an old shims not ported to new format.

this is a problem, since we should still warn about this even if there is no equivalent in the new mappings... 🤔

rwjblue · 2017-09-19T12:45:41Z

Ya, we should explicitly support having deprecated: true without a replacement value.

Serabe · 2017-09-19T13:08:00Z

Then either the old-shims file should not be removed or the data that was lost in translation brought back.

rwjblue · 2017-09-19T13:08:36Z

Hmm, not sure I'm following. All of the old shims data is included in the new mappings.json file isn't it?

rwjblue · 2017-09-19T13:13:01Z

Chatted with @Serabe in slack about this, and summarized in ember-cli/ember-rfc176-data#37 (comment).

Turbo87 · 2017-09-19T15:36:02Z

we might also want to think about adding an fromOldShims: true to the relevant entries, otherwise at some point this rule will start warning about deprecated imports that are not actually part of the old shims

Serabe · 2017-09-19T16:28:54Z

Right.

rwjblue · 2017-09-19T19:30:06Z

Ya, but I actually think a general rule for no-deprecated-modules is a better overall path forward anyways...

Turbo87 · 2017-09-20T15:21:09Z

Ya, but I actually think a general rule for no-deprecated-modules is a better overall path forward anyways...

I tend to disagree. The ember-cli-shims are deprecated independent of the Ember version that is used, but the other things might depend on the Ember version. In other words: if I'm on an old Ember version I do want to disallow the old shims, but I might not want to disallow legitimate API that is not yet deprecated in the Ember version that I'm using.

rwjblue · 2017-09-20T16:49:26Z

In other words: if I'm on an old Ember version I do want to disallow the old shims, but I might not want to disallow legitimate API that is not yet deprecated in the Ember version that I'm using.

Yep, totally agreed. At the moment we only have things that should have always worked, but I totally agree that at some future time we could deprecate a module in favor of some replacement that doesn't exist for certain Ember versions. This doesn't mean my suggested path forward is wrong 😉, it just means we need more data than deprecated: true.

For deprecations as of a specific Ember version, we should encode that into the updated mappings.json file format. I'm thinking deprecated: '1.2.3' (where its as of that specific version, and we can check Ember version against this string)...

Turbo87 · 2017-09-20T16:51:59Z

what we could do is have a static list of module paths in this plugin that were part of ember-cli-shims and only warn if we detect an import from such a module path. I'm not sure that information needs to live in the RFC data repo 🤔

michalsnik · 2017-09-22T08:53:56Z

I agree with @Turbo87, but having a static list of modules used in ember-cli-shims will make it impossible to automatically fix those imports to recommended ones wouldn't it?

Turbo87 · 2017-09-22T09:04:47Z

but having a static list of modules used in ember-cli-shims will make it impossible to automatically fix those imports to recommended ones wouldn't it?

I don't understand why that would be a problem? 🤔

Serabe · 2017-09-29T13:30:23Z

I need to keep the force upgrade of ember-rfc176-data or the tests won't pass. I'll update once ember-rfc176-data has been updated.

rwjblue · 2017-10-03T15:02:26Z

Ready to update to point at [email protected] now that it is published.

Serabe · 2017-10-03T23:04:48Z

@rwjblue done!

rwjblue · 2017-11-15T14:15:52Z

.travis.yml

@@ -8,6 +8,7 @@ node_js:
 cache: yarn

 script:
+  - yarn upgrade ember-rfc176-data


I don't think this should be needed any more...

rwjblue · 2017-11-15T14:18:23Z

package.json

@@ -53,7 +53,7 @@
    "jest": "^20.0.4"
  },
  "dependencies": {
-    "ember-rfc176-data": "^0.2.7",
+    "ember-rfc176-data": "~0.3.0",


Should probably still be ^0.3.0 (it just has the same effect as ~0.3.0 in this case)

This PR adapts the code to the new format in ember-cli/ember-rfc176-data#37 This also removes a line testing an old shims not ported to new format.

rwjblue · 2018-05-14T20:03:31Z

I just updated with:

removing the no-deprecated-module rule (for now, but will make separate PR preserving authorship for that after this lands)
Fixing a few conflicts
Inline data for no-old-shims rule

Turbo87

can you add a test for Ember.String.htmlSafe to check that we're handling the deprecated flag correctly?

rwjblue · 2018-05-14T20:14:22Z

can you add a test for Ember.String.htmlSafe to check that we're handling the deprecated flag correctly?

sure, also still working on a few of the remaining failures (seem related to destructuring)

rwjblue · 2018-05-15T20:23:59Z

can you add a test for Ember.String.htmlSafe to check that we're handling the deprecated flag correctly?

We already had a test for htmlSafe, I updated the expectation to the correct value...

Turbo87 · 2018-05-15T20:28:08Z

hmm, about the htmlSafe, do we eventually need to care about the ember-source version that is used?

rwjblue · 2018-05-15T20:33:35Z

hmm, about the htmlSafe, do we eventually need to care about the ember-source version that is used?

yes, but not now 😄, both import { htmlSafe } from '@ember/string' and import { htmlSafe } from '@ember/template' currently point to Ember.String.htmlSafe

Serabe force-pushed the feature/new-data-format branch from 7b2e462 to 3153224 Compare September 18, 2017 23:09

Serabe mentioned this pull request Sep 18, 2017

New mappings structure ember-cli/ember-rfc176-data#37

Merged

michalsnik added the Discussion label Sep 22, 2017

Serabe force-pushed the feature/new-data-format branch 2 times, most recently from c3143e3 to fa1bc9f Compare September 29, 2017 13:26

Turbo87 added internal and removed Discussion labels Nov 15, 2017

rwjblue reviewed Nov 15, 2017

View reviewed changes

Serabe added 6 commits May 14, 2018 15:41

Port code to ember-rfc176-data new format

c06f729

This PR adapts the code to the new format in ember-cli/ember-rfc176-data#37 This also removes a line testing an old shims not ported to new format.

Point ember-rfc176-data to PR branch

9d4a901

Undo destructuring to support Node 4 :'(

25b8561

Create no-deprecated-modules rule and deprecate no-old-shims rule.

4046121

Update no-old-shims rule

7f25c2b

Force upgrade of ember-rfc176-data

91a11c6

Serabe and others added 3 commits May 14, 2018 15:45

Update to [email protected]

1c01596

Remove new no-deprecated-modules rule.

065602d

Inline old shim data into no-old-shims rule.

5468e62

rwjblue force-pushed the feature/new-data-format branch from 8a12d8b to 5468e62 Compare May 14, 2018 20:00

Turbo87 reviewed May 14, 2018

View reviewed changes

rwjblue added 3 commits May 15, 2018 15:17

Fix destructuring support with new-module-imports.

7a12560

Update to [email protected].

46cf0ce

Fixup tests with latest ember-rfc176-data.

2277e29

rwjblue requested a review from Turbo87 May 15, 2018 20:24

Turbo87 approved these changes May 15, 2018

View reviewed changes

rwjblue merged commit 098f865 into ember-cli:master May 15, 2018

rwjblue added the enhancement label May 15, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port code to ember-rfc176-data new format #142

Port code to ember-rfc176-data new format #142

Serabe commented Sep 18, 2017

Turbo87 commented Sep 19, 2017

rwjblue commented Sep 19, 2017

Serabe commented Sep 19, 2017

rwjblue commented Sep 19, 2017

rwjblue commented Sep 19, 2017

Turbo87 commented Sep 19, 2017

Serabe commented Sep 19, 2017

rwjblue commented Sep 19, 2017

Turbo87 commented Sep 20, 2017

rwjblue commented Sep 20, 2017 •

edited

Loading

Turbo87 commented Sep 20, 2017

michalsnik commented Sep 22, 2017

Turbo87 commented Sep 22, 2017

Serabe commented Sep 29, 2017

rwjblue commented Oct 3, 2017 •

edited

Loading

Serabe commented Oct 3, 2017

rwjblue Nov 15, 2017

rwjblue Nov 15, 2017

rwjblue commented May 14, 2018

Turbo87 left a comment

rwjblue commented May 14, 2018

rwjblue commented May 15, 2018

Turbo87 commented May 15, 2018

rwjblue commented May 15, 2018

Port code to ember-rfc176-data new format #142

Port code to ember-rfc176-data new format #142

Conversation

Serabe commented Sep 18, 2017

Turbo87 commented Sep 19, 2017

rwjblue commented Sep 19, 2017

Serabe commented Sep 19, 2017

rwjblue commented Sep 19, 2017

rwjblue commented Sep 19, 2017

Turbo87 commented Sep 19, 2017

Serabe commented Sep 19, 2017

rwjblue commented Sep 19, 2017

Turbo87 commented Sep 20, 2017

rwjblue commented Sep 20, 2017 • edited Loading

Turbo87 commented Sep 20, 2017

michalsnik commented Sep 22, 2017

Turbo87 commented Sep 22, 2017

Serabe commented Sep 29, 2017

rwjblue commented Oct 3, 2017 • edited Loading

Serabe commented Oct 3, 2017

rwjblue Nov 15, 2017

Choose a reason for hiding this comment

rwjblue Nov 15, 2017

Choose a reason for hiding this comment

rwjblue commented May 14, 2018

Turbo87 left a comment

Choose a reason for hiding this comment

rwjblue commented May 14, 2018

rwjblue commented May 15, 2018

Turbo87 commented May 15, 2018

rwjblue commented May 15, 2018

rwjblue commented Sep 20, 2017 •

edited

Loading

rwjblue commented Oct 3, 2017 •

edited

Loading