Fix issue cannot create two files of the same type, even if the name is different #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is it possible to add a regression test? |
|
@stefanpenner Yes, done. |
|
wunderbar |
| generateIdForRecord: function(store, type, inputProperties) { | ||
| return inputProperties.filePath.replace(/\//gi, '.'); | ||
| return inputProperties.filePath.replace(/\//gi, '.') + "." + this.incrementProperty('seq'); |
There was a problem hiding this comment.
Instead of allowing duplicate filePath's, I think that we should delay calling store.createRecord until after we have prompted for the file name.
We should:
- Add a
build(orbuildProperties) toember-cliservice. - Move main logic out of
generateintobuild, leavinggenerateas roughlyreturn this.store.createRecord('gistFile', this.build(type));. - Update
addNewaction ingist/controller.jsto callbuild, then prompt, then createRecord.
|
@rwjblue How's this? |
|
Above was just to get Travis to test this. Please review. |
|
Looks good to me, thanks for working on this! |
rwjblue
added a commit
that referenced
this pull request
Jul 27, 2015
…type Fix issue cannot create two files of the same type, even if the name is different
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #79