Build a html string from services/ember-cli #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 to the changes, would you mind adding a super simple unit test as a starting point for future testing initiatives? |
|
@joostdevries While definitely simpler, I want to ensure that we don't expose index.html to the user until we know we've ensured he can't break the app (other than the build of his own app) with it. |
|
@Gaurav0 at this point it's not exposed as I'm taking it directly out of |
added 2 commits
July 30, 2015 19:54
|
@rwjblue test :-) |
| var service = this.subject(); | ||
| assert.ok(service); | ||
|
|
||
| var gist = Ember.Object.create({ |
There was a problem hiding this comment.
using actual models here overcomplicated things, so I chose to use normal objects.
|
👍 - Looks good, left one small comment... |
joostdevries
pushed a commit
that referenced
this pull request
Jul 30, 2015
Build a html string from services/ember-cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My idea is basically to have all of the build logic in
services/ember-cliso that we don't have to do the same stuff in multiple places.. That way we can probably also unit-testservices/ember-cliand have a pretty good baseline for overall functionality