Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember to 3.4 #672

Merged
merged 5 commits into from
Feb 25, 2020
Merged

Update ember to 3.4 #672

merged 5 commits into from
Feb 25, 2020

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Feb 25, 2020

No description provided.

@gokatz
Copy link
Member

gokatz commented Feb 25, 2020

really great to see twiddle is moving towards Octane 💯

One small clarification regarding the preview deployment. Do we have netlify (or any other host) previews for PRs?

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Feb 25, 2020

Not for PRs. Once merged to master, https://canary.ember-twiddle.com gets updated.

@Gaurav0 Gaurav0 merged commit 21d4367 into ember-cli:master Feb 25, 2020
@Gaurav0 Gaurav0 deleted the update_ember_to_3.4 branch February 25, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants