Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add author of gist and original author (forked gist) #656

Merged
merged 12 commits into from
May 3, 2019
Merged

Add author of gist and original author (forked gist) #656

merged 12 commits into from
May 3, 2019

Conversation

romgere
Copy link
Contributor

@romgere romgere commented May 3, 2019

#403 Add a footer with author informations + original author and link to open gist in ember-twiddle for forked gist.
127 0 0 1_4200_0bceff193ce347a84109b14754f51f71

Copy link
Contributor

@knownasilya knownasilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small tweaks, but looks good overall.

app/templates/components/user-profil-link.hbs Outdated Show resolved Hide resolved
app/components/gist-footer.js Outdated Show resolved Hide resolved
app/styles/_footer.scss Outdated Show resolved Hide resolved
app/styles/_footer.scss Outdated Show resolved Hide resolved
app/styles/_footer.scss Outdated Show resolved Hide resolved
app/styles/_twiddle-panes.scss Outdated Show resolved Hide resolved
app/templates/components/gist-footer.hbs Outdated Show resolved Hide resolved
app/templates/components/main-gist.hbs Outdated Show resolved Hide resolved
@knownasilya knownasilya merged commit f60b07d into ember-cli:master May 3, 2019
@Gaurav0 Gaurav0 mentioned this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants